Fix Array interface (#10886)#11294
Conversation
|
What's the bug tracking this change? |
|
Fixes #10886 |
|
Can someone review this? |
|
sorry for the late reply. can you refresh this PR? |
|
done |
|
now updating |
There was a problem hiding this comment.
#10886 is not acceptable because of confusing with tuple types.
| >regExpExecArrayValue.slice() : string[] | ||
| >regExpExecArrayValue.slice : (start?: number, end?: number) => string[] | ||
| >regExpExecArrayValue.slice() : RegExpExecArray | ||
| >regExpExecArrayValue.slice : (start?: number, end?: number) => RegExpExecArray |
There was a problem hiding this comment.
Wrong, must return string[]. It can avoid by overloading in RegExpExecArray and RegExpMatchArray.
| >t.slice() : [number, string] | ||
| >t.slice : { (start?: number, end?: number): (string | number)[]; (): [number, string]; } | ||
| >t.slice : { (start?: number, end?: number): [number, string]; (): [number, string]; } | ||
| >t : [number, string] |
There was a problem hiding this comment.
Wrong, concat and slice methods must not return this type when it is a tuple type. It cannot avoid.
|
improved. i tried to improve RegExp{Exec,Match}Array too, interface RegExpMatchArray extends Array<string> {
index?: number;
input?: string;
concat(): string[];
slice(start?: 0): string[];
}
interface RegExpExecArray extends Array<string> {
index: number;
input: string;
concat(): string[];
slice(start?: 0): string[];
}but i didn't complete that because it makes 637 errors. i cannot fix such a lot of errors. |
|
@mhegazy can you review before conflicting again? |
|
@RyanCavanaugh @ahejlsberg @DanielRosenwasser @sandersn @vladima @zhengbli @weswigham can you review instead of him? |
|
Fixed by #12784 |
4 participants
No description provided.